servala/servala-portal

Fork 0

October feature list #226

Merged

tobru merged 36 commits from october into main

2025-10-22 13:43:34 +00:00

rixx commented

2025-10-17 03:57:21 +00:00

Member

Sorry for the giant PR, but some features soft-depended on each other, and migrations are also hard to keep separate. This PR contains:

#38: Filtering based on cloud providers configured in the organisation origin + deactivating services that were not explicitly activated via OSB
#198: Default billing entity configuration based on origin. Will not work if there is a billing entity set on the default origin, but will work (and is tested with) a billing entity on e.g. the exoscale origin
#19: Users can invite other users into their organisation at their level or lower. Currently only implemented for admins and owners, not for regular members. Works for logged-in and not-logged-in users both. If the user email address does not match the invoice email address, a warning is shown. Not implemented yet: retracting invitations. Invitations are also used for exoscale org creations.
#197: External links for service offerings
#200: Hiding HOST keys in credentials (untested because I didn't have an instance with visible credentials set up)
#202: Roll back service instance creation if the control plane or API throws an error
#203: Generate/suggest FQDN based on configurable control plane setting
#204: Hiding configurable advanced parameters + improving generated display of labels (the postgre s q l problem)
#224: Debouncing the "add item" button

Not included, because stuck:

#201: Improve detection of mandatory fields. As far as I can tell, the spec does not contain the data we need – I think what we want, in principle, are validation rules with CEL expressions – are those already present? Haven't looked deeper into it yet.

Sorry for the giant PR, but some features soft-depended on each other, and migrations are also hard to keep separate. This PR contains: - #38: Filtering based on cloud providers configured in the organisation origin + deactivating services that were not explicitly activated via OSB - #198: Default billing entity configuration based on origin. Will *not* work if there is a billing entity set on the default origin, but will work (and is tested with) a billing entity on e.g. the exoscale origin - #19: Users can invite other users into their organisation at their level or lower. Currently only implemented for admins and owners, not for regular members. Works for logged-in and not-logged-in users both. If the user email address does not match the invoice email address, a warning is shown. Not implemented yet: retracting invitations. Invitations are also used for exoscale org creations. - #197: External links for service offerings - #200: Hiding HOST keys in credentials (untested because I didn't have an instance with visible credentials set up) - #202: Roll back service instance creation if the control plane or API throws an error - #203: Generate/suggest FQDN based on configurable control plane setting - #204: Hiding configurable advanced parameters + improving generated display of labels (the `postgre s q l` problem) - #224: Debouncing the "add item" button **Not** included, because stuck: - #201: Improve detection of mandatory fields. As far as I can tell, the spec does not contain the data we need – I think what we want, in principle, are [validation rules with CEL expressions](https://kubernetes.io/docs/tasks/extend-kubernetes/custom-resources/custom-resource-definitions/#validation-rules) – are those already present? Haven't looked deeper into it yet.

rixx added 19 commits 2025-10-17 03:57:21 +00:00

Code style 272451c92f

Add new limitation fields to Organization model a644ad4e75

ref #38

Only show services with permitted CloudProvider df3e3d5f0c

ref #38

Add services to limit_osb_services on activation 3730d95a6e

ref #38

Show non-deactivated services separately 819e13481e

ref #38

Add default billing entity from origin 6443582c0e

ref #198

Prepare to block billing entity editing 842b66a84d

ref #198

Add Invitation model 8b1e0f74bb

ref #19

Allow users to accept invitations 09ab83d1e4

ref #19

Allow users to invite other users 21c26f9e5d

ref #19

Send invitation emails b9ff0e61da

ref #19

Add external links to service offerings 4bf35260ad

ref #197

Do not display _HOST keys in connection details 27b9133ad4

ref #200

Roll back service creation on error 72fedefb7f

ref #202

Add wildcard_dns field 573b7a5eb5

ref #203

Generate wildcard DNS in frontend 3375a1c8f3

ref #203

Fix common abbreviations 4124add146

ref #204

Add ServiceDefinition.advanced_fields cd886df05b

ref #204

Allow users to toggle advanced fields

Tests / test (push) Successful in 58s

Details

3101829885

ref #204

rixx added 1 commit 2025-10-17 04:12:48 +00:00

Fix "Add item" button adding multiple items

Tests / test (push) Successful in 1m12s

Details

8ba9787d4b

ref #224

tobru added 2 commits 2025-10-17 08:40:51 +00:00

remove the help text about billing entity being read only 014e88aa24

The issue is that when obj.has_inherited_billing_entity is True, the code adds
"billing_entity" to the readonly fields.

When a field is marked as readonly, Django may exclude it from form.base_fields,
which causes a KeyError when trying to access it.

explicitely convert is_accepted to boolean

Tests / test (push) Successful in 31s

Details

54998ab9d0

The is_accepted property returns self.accepted_by or self.accepted_at.
When accepted_by is a User object (not None), it returns the User object
instead of a boolean.

The Django admin's boolean field renderer expects a boolean value
(True, False, or None), not a User object.

tobru added 1 commit 2025-10-17 08:55:00 +00:00

service enabling / disabling is not specific to a csp

Tests / test (push) Successful in 48s

Details

ce34afa10a

rixx added 7 commits 2025-10-21 16:14:18 +00:00

Fix advanced fields not working with array fields 359bc58749