servala/servala-portal
3
0
Fork 0
Code Issues 21 Pull requests 5 Projects 2 Releases Packages 2 Activity Actions

Fix permission issue for editing or deleting instances #151

Merged
tobru merged 3 commits from 148-instance-edit-permissions into main 2025-07-11 14:55:48 +00:00
Conversation 3 Commits 3 Files changed 2 +19 -4
2 changed files with 19 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/servala/core/models/service.py
View file

@ -571,7 +571,7 @@ class ServiceInstance(ServalaModelMixin, models.Model):
unique_together = [("name", "organization", "context")]
rules_permissions = {
"view": rules.is_staff | perms.is_organization_member,
"change": rules.is_staff | perms.is_organization_member,
"change": rules.is_staff | perms.is_organization_admin,
"delete": rules.is_staff | perms.is_organization_admin,
"add": rules.is_authenticated,
}

21
src/servala/core/rules.py
View file

@ -13,15 +13,30 @@ def has_organization_role(user, org, roles):
@rules.predicate
def is_organization_owner(user, org):
def is_organization_owner(user, obj):
if hasattr(obj, "organization"):
org = obj.organization
else:
org = obj
return has_organization_role(user, org, ["owner"])
@rules.predicate
def is_organization_admin(user, org):
def is_organization_admin(user, obj):
if hasattr(obj, "organization"):
org = obj.organization
else:
org = obj
return has_organization_role(user, org, ["owner", "admin"])
@rules.predicate
def is_organization_member(user, org):
def is_organization_member(user, obj):
if hasattr(obj, "organization"):
org = obj.organization
else:
org = obj
return has_organization_role(user, org, None)
rules.add_perm("core", rules.is_staff)