docs(backups): deleting an instance deletes its backup bucket #30

Open

aarno.aukia wants to merge 1 commit from docs/backups-deleted-with-instance into main

aarno.aukia commented

2026-11-05 10:18:26 +00:00

Member

The backups page said the bucket "is retained for the configured retention period after backups are disabled or the instance is deleted". The second half does not match the code.

AppCat deletes the backup bucket with the instance: the bucket is an XObjectBucket with the default bucketDeletionPolicy: DeleteAll, and the webhook in pkg/controller/webhooks/xobjectbuckets.go lets the delete through once the owning instance is being deleted (vshn/appcat develop, ba57ce4, 2026-11-04). Only disabling backups keeps the bucket, for KeepDaily days after the appcat.vshn.io/backup-disabled-timestamp label. The old 7-day retention after deletion (deletionRetention) was removed in vshn/appcat d145fc03 (2024-07-23).

The caveat now says deleting the instance deletes its backups, so download or restore first, and keeps the disable case.

Matching fixes: vshn/appcat-user-docs PR 303 (PostgreSQL create page), vshn/docs/products MR 385 (appcat/data_protection.html). how-to/manage-instances.md ("All data associated with the instance will be lost") was already correct.

Generated with Claude Code

The backups page said the bucket "is retained for the configured retention period after backups are disabled or the instance is deleted". The second half does not match the code. AppCat deletes the backup bucket with the instance: the bucket is an `XObjectBucket` with the default `bucketDeletionPolicy: DeleteAll`, and the webhook in `pkg/controller/webhooks/xobjectbuckets.go` lets the delete through once the owning instance is being deleted (vshn/appcat `develop`, ba57ce4, 2026-11-04). Only disabling backups keeps the bucket, for `KeepDaily` days after the `appcat.vshn.io/backup-disabled-timestamp` label. The old 7-day retention after deletion (`deletionRetention`) was removed in vshn/appcat d145fc03 (2024-07-23). The caveat now says deleting the instance deletes its backups, so download or restore first, and keeps the disable case. Matching fixes: vshn/appcat-user-docs PR 303 (PostgreSQL create page), vshn/docs/products MR 385 (appcat/data_protection.html). `how-to/manage-instances.md` ("All data associated with the instance will be lost") was already correct. Generated with Claude Code

aarno.aukia added 1 commit

2026-11-05 10:18:26 +00:00

docs(backups): deleting an instance deletes its backup bucket 1e7966b954

The page said the bucket is retained for the retention period after the
instance is deleted. AppCat deletes the backup bucket with the instance
(bucketDeletionPolicy DeleteAll, vshn/appcat develop ba57ce4); only
disabling backups keeps it, for KeepDaily days.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

aarno.aukia requested review from tobru

2026-11-05 10:18:58 +00:00

This pull request can be merged automatically.

You are not authorized to merge this pull request.

View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u origin docs/backups-deleted-with-instance:docs/backups-deleted-with-instance

git switch docs/backups-deleted-with-instance

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch main

git merge --no-ff docs/backups-deleted-with-instance

git switch docs/backups-deleted-with-instance

git rebase main

git switch main

git merge --ff-only docs/backups-deleted-with-instance

git switch docs/backups-deleted-with-instance

git rebase main

git switch main

git merge --no-ff docs/backups-deleted-with-instance

git switch main

git merge --squash docs/backups-deleted-with-instance