servala/documentation
5
1
Fork 0
Code Issues Pull requests 1 Packages 1 Activity Actions

ADR for Servala Control Plane Architecture #1

Merged
marco.deluca merged 1 commit from adr/control-plane into main 2025-12-08 13:42:44 +00:00
Conversation 3 Commits 1 Files changed 2 +64 -4
marco.deluca commented 2025-12-08 13:14:11 +00:00
Member
Copy link
No description provided.
marco.deluca added 1 commit 2025-12-08 13:14:12 +00:00
marco.deluca self-assigned this 2025-12-08 13:14:21 +00:00
simon.beck approved these changes 2025-12-08 13:25:15 +00:00
simon.beck left a comment
Member
Copy link

LGTM

Just a few nitpicks about the role of the control panel.

LGTM Just a few nitpicks about the role of the control panel.
👍 1
docs/ADRs/adr001.md Outdated
@ -16,3 +64,4 @@
## Decision
We've decided to move away from the split control plane architecture and instead let the Servala Portal handle orchestration.
simon.beck commented 2025-12-08 13:23:15 +00:00
Member
Copy link

The portal did the orchestration already. It had to tell the control plane which service clusters should get used.

The portal did the orchestration already. It had to tell the control plane which service clusters should get used.
docs/ADRs/adr001.md Outdated
@ -21,0 +88,4 @@
#### What We're Trading Off
The Portal becomes critical infrastructure for orchestration. If it's down, orchestration stops.
simon.beck commented 2025-12-08 13:21:53 +00:00
Member
Copy link

This statement is also true with split architecture, as the control panel still did the orchestration.

This statement is also true with split architecture, as the control panel still did the orchestration.
tobru added 1 commit 2025-12-08 13:31:36 +00:00
tobru commented 2025-12-08 13:32:22 +00:00
Owner
Copy link

Besides the comments from @simon.beck and my small edit in 77a0d02d2e - LGTM

Besides the comments from @simon.beck and my small edit in 77a0d02d2e2ee711d7e4786a1e82851ca5e356df - LGTM
👍 1
requested review from tobru 2025-12-08 13:32:31 +00:00
tobru approved these changes 2025-12-08 13:32:42 +00:00
marco.deluca force-pushed adr/control-plane from 77a0d02d2e to df380a4bd6 2025-12-08 13:36:51 +00:00 Compare
marco.deluca force-pushed adr/control-plane from df380a4bd6 to cf24cec7b7 2025-12-08 13:41:45 +00:00 Compare
marco.deluca merged commit 8c64107789 into main 2025-12-08 13:42:44 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
simon.beck
tobru
Labels
Clear labels
  
bug

Something is not working

  
change

Change an existing feature

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No labels
bug
change
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
marco.deluca
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: servala/documentation#1
No description provided.
Delete branch "adr/control-plane"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?