I'm not entirely clear on the "Learn more" link per service offering – everything else should be resolved, though configuring the links requires entering JSON (documented structure) manually.
@tobru Hm, but that's what's meant to happen regardless – you can see that Django uses the django-rules permissions in User.has_perm
by checking out this PR and comparing the look of the admin…
Display links stored in "External links". Proposal for the structure: link name, URL. This way we can add more links, for example to the service documentation.
Followed this setup, except…
The permissions should be using django-rules – we use the idiomatic User.has_perm()
which delegates to auth frameworks like django-rules. We currently set the model permission rules in the…
Using mark_safe means that we trust k8s error messages to never contain valid markup/other injections, e.g. by way of user-defined names. I don't know enough about how k8s errors look and are processed, just wanted to point that out.
Looks good to me! One comment on using mark_safe
on input that we do not control directly, which I don't have enough k8s knowledge to judge (should be safe?), ready to merge from my POV.