Tobias Kunze rixx · he/him
rixx commented on pull request servala/servala-portal#152 2025-08-01 11:23:49 +00:00
Service pages improvements

I'm not entirely clear on the "Learn more" link per service offering – everything else should be resolved, though configuring the links requires entering JSON (documented structure) manually.

rixx pushed to 132-frontend-improvements at servala/servala-portal 2025-08-01 11:23:37 +00:00
3c14c312d7 Document external_links schema
rixx pushed to 132-frontend-improvements at servala/servala-portal 2025-08-01 11:19:58 +00:00
e0d05302b5 Display service offering description (if any)
72920b21ad Show external links on offering detail page
Compare 2 commits »
rixx pushed to 132-frontend-improvements at servala/servala-portal 2025-08-01 11:11:39 +00:00
5b876de18a Code style
18dc93fd96 Show external links on service detail page
98f759a936 Fix code style
ab4552e283 Show featured links
f4e8d7dcb7 Make sure service cards have consistent height
Compare 25 commits »
rixx commented on pull request servala/servala-portal#151 2025-07-11 14:39:10 +00:00
Fix permission issue for editing or deleting instances

@tobru Hm, but that's what's meant to happen regardless – you can see that Django uses the django-rules permissions in User.has_perm by checking out this PR and comparing the look of the admin…

rixx pushed to 148-instance-edit-permissions at servala/servala-portal 2025-07-11 14:38:58 +00:00
0bd895c486 Make rules compatible with instance checks
rixx commented on pull request servala/servala-portal#149 2025-07-11 14:29:16 +00:00
Include link to support in error message

Looks good to me!

rixx pushed to 132-frontend-improvements at servala/servala-portal 2025-07-11 11:23:09 +00:00
e24e368654 Code style
487317bb43 Show external links on service detail page
208c07e58b Fix code style
Compare 3 commits »
rixx created pull request servala/servala-portal#152 2025-07-11 11:22:44 +00:00
WIP: Service pages improvements
rixx pushed to 132-frontend-improvements at servala/servala-portal 2025-07-11 11:20:52 +00:00
3c365c0824 Code style
160734e9d4 fixup! Fix code style
7975d0a00e Show external links on service detail page
73d9153eca Fix code style
2567c8455c Show featured links
Compare 6 commits »
rixx created branch 132-frontend-improvements in servala/servala-portal 2025-07-11 11:20:51 +00:00
rixx commented on issue servala/servala-portal#132 2025-07-11 11:16:37 +00:00
Service listing, detail and offering page improvements

Display links stored in "External links". Proposal for the structure: link name, URL. This way we can add more links, for example to the service documentation.

Followed this setup, except…

rixx commented on issue servala/servala-portal#131 2025-07-11 10:28:12 +00:00
Service instance edit and delete permissions tied to Django permissions

The permissions should be using django-rules – we use the idiomatic User.has_perm() which delegates to auth frameworks like django-rules. We currently set the model permission rules in the…

rixx pushed to 148-instance-edit-permissions at servala/servala-portal 2025-07-11 10:25:55 +00:00
5feabda513 Make sure admin is visible to staff users
3f8901aa93 Try to fix permissions issue
Compare 2 commits »
rixx created pull request servala/servala-portal#151 2025-07-11 10:17:29 +00:00
Try to fix permissions issue
rixx created branch 148-instance-edit-permissions in servala/servala-portal 2025-07-11 10:14:36 +00:00
rixx pushed to 148-instance-edit-permissions at servala/servala-portal 2025-07-11 10:14:36 +00:00
4c0a656ed4 Try to fix permissions issue
rixx commented on pull request servala/servala-portal#149 2025-07-11 10:09:37 +00:00
Include link to support in error message

Using mark_safe means that we trust k8s error messages to never contain valid markup/other injections, e.g. by way of user-defined names. I don't know enough about how k8s errors look and are processed, just wanted to point that out.

rixx commented on pull request servala/servala-portal#149 2025-07-11 10:09:37 +00:00
Include link to support in error message

Looks good to me! One comment on using mark_safe on input that we do not control directly, which I don't have enough k8s knowledge to judge (should be safe?), ready to merge from my POV.

rixx pushed to main at servala/servala-portal 2025-07-11 09:50:46 +00:00
a54b1b1108 Merge pull request 'Update dependency django-allauth to >=65.10.0' (#150) from renovate/django-allauth-65.x into main
fdb07b89b9 Update dependency django-allauth to >=65.10.0
Compare 2 commits »