Tobias Kunze rixx · he/him
rixx deleted branch renovate/django-allauth-65.x from servala/servala-portal 2025-07-11 09:50:46 +00:00
rixx merged pull request servala/servala-portal#150 2025-07-11 09:50:45 +00:00
Update dependency django-allauth to >=65.10.0
rixx commented on pull request servala/servala-portal#143 2025-07-07 12:06:48 +00:00
refactor odoo company type handling

haha sorry, I use apostrophes by default when writing text (as opposed to code), but I suppose that does look odd in some IDEs …

rixx approved servala/servala-portal#143 2025-07-07 12:06:48 +00:00
refactor odoo company type handling

LGTM

rixx commented on pull request servala/servala-portal#149 2025-07-07 11:59:27 +00:00
Include link to support in error message

The full message doesn’t need to be an i18n string – better off as just as f"{message} {support_message}"

rixx commented on pull request servala/servala-portal#149 2025-07-07 11:59:27 +00:00
Include link to support in error message

I don't think comments like this add much to the code, FWIW (of course up to you if you want to keep it).

rixx commented on pull request servala/servala-portal#149 2025-07-07 11:59:27 +00:00
Include link to support in error message

Pretty repetitive to have this method on both the form and the view – I think it’d be cleaner to centralise this:

rixx commented on pull request servala/servala-portal#149 2025-07-07 11:59:27 +00:00
Include link to support in error message

LGTM – can be merged as-is, just some suggestions for possibly better code structure.

rixx commented on issue servala/servala-portal#124 2025-06-26 15:33:54 +00:00
Do not pass empty Arrays

Implemented the former assumption in #126

rixx created pull request servala/servala-portal#126 2025-06-26 15:33:40 +00:00
Prune empty data from instance payloads
rixx created branch 124-empty-values in servala/servala-portal 2025-06-26 15:33:20 +00:00
rixx pushed to 124-empty-values at servala/servala-portal 2025-06-26 15:33:20 +00:00
3236fc7b21 Prune empty data from instance updates aswell
6c6fb06a01 Prune empty values before creating instance
Compare 2 commits »
rixx commented on issue servala/servala-portal#124 2025-06-26 15:31:08 +00:00
Do not pass empty Arrays

I assume that any objects containing no data should be omitted, right, @tobru? Or should they instead be set to null?

rixx pushed to main at servala/servala-portal 2025-06-26 15:22:15 +00:00
d5ad664bca Merge pull request 'Fix ValueError' (#125) from 123-value-error into main
dabf758ced Fix bug exclusive to second-level config fields
493f68eedf Make loop more efficient
Compare 3 commits »
rixx deleted branch 123-value-error from servala/servala-portal 2025-06-26 15:22:15 +00:00
rixx merged pull request servala/servala-portal#125 2025-06-26 15:22:14 +00:00
Fix ValueError
rixx closed issue servala/servala-portal#123 2025-06-26 15:22:14 +00:00
'list' object has no attribute 'values'
rixx created pull request servala/servala-portal#125 2025-06-26 15:22:08 +00:00
Fix ValueError
rixx created branch 123-value-error in servala/servala-portal 2025-06-26 15:21:51 +00:00