Tobias Brunner tobru · he/him
0 followers · 0 following
Repositories Projects Packages Code Public activity Starred repositories
tobru commented on pull request servala/servala-portal#149 2025-07-11 12:44:42 +00:00
Include link to support in error message

With the help of Copilot and some manual tweaking / reviewing I was able to introduce a way to sanitize the error messages, which certainly makes sense. I hope it's not overengineered now.

tobru pushed to error-with-help at servala/servala-portal 2025-07-11 12:43:39 +00:00
8a45a22759 sanitize kubernetes messages
tobru commented on pull request servala/servala-portal#151 2025-07-11 12:18:51 +00:00
Fix permission issue for editing or deleting instances

@rixx Unfortunately, no. A regular user without any Django permissions (staff or superuser) cannot edit or delete a service instance. IMHO we should not rely on the Django permissions but on the…

tobru commented on pull request servala/servala-portal#149 2025-07-10 14:34:02 +00:00
Include link to support in error message

@rixx Thanks for the review. I iterated over it again, and I'm happy to get another review before merging it.

tobru pushed to error-with-help at servala/servala-portal 2025-07-10 14:32:44 +00:00
9c3ce54bb3 format and retext control plane errors
9317547630 restore translated strings
Compare 2 commits »
tobru pushed to error-with-help at servala/servala-portal 2025-07-10 14:11:49 +00:00
3c270d9c12 refactor into a shared function
tobru commented on pull request servala/servala-portal#148 2025-07-08 09:21:55 +00:00
Use organization role to check for edit and delete perms of service instances

May I assign this PR to you to clean up as proposed?

tobru deleted branch odoo-company-check from servala/servala-portal 2025-07-07 12:11:32 +00:00
tobru pushed to main at servala/servala-portal 2025-07-07 12:11:31 +00:00
24cb249e9e Merge pull request 'refactor odoo company type handling' (#143) from odoo-company-check into main
76bc37e3f0 refactor odoo company type handling
Compare 2 commits »
tobru merged pull request servala/servala-portal#143 2025-07-07 12:11:30 +00:00
refactor odoo company type handling
tobru commented on pull request servala/servala-portal#149 2025-07-07 11:39:36 +00:00
Include link to support in error message

I'm not entirely happy with the implementation, but this is what I could come up with. Maybe there is a better / simpler way to do that?

tobru created pull request servala/servala-portal#149 2025-07-07 11:38:51 +00:00
Include link to support in error message
tobru created branch error-with-help in servala/servala-portal 2025-07-07 11:38:16 +00:00
tobru pushed to error-with-help at servala/servala-portal 2025-07-07 11:38:16 +00:00
5fa3d32c57 do not dismiss message when error message
e78a63c67f add link to support form on error message
Compare 2 commits »
tobru created pull request servala/servala-portal#148 2025-07-07 11:11:53 +00:00
Use organization role to check for edit and delete perms of service instances
tobru created branch instance-edit-permi-from-org in servala/servala-portal 2025-07-07 11:11:26 +00:00
tobru pushed to instance-edit-permi-from-org at servala/servala-portal 2025-07-07 11:11:26 +00:00
46d323528e use organization role to check for edit and delete perms
tobru commented on issue servala/servala-portal#141 2025-07-07 09:43:56 +00:00
Instance filter form misses text

Fixed in afde1a5f96. Decided not to filter the list for now, behaves as before.

tobru closed issue servala/servala-portal#141 2025-07-07 09:43:56 +00:00
Instance filter form misses text
tobru pushed to main at servala/servala-portal 2025-07-07 09:43:15 +00:00
afde1a5f96 show provider name in instance filter dropdown