servala/servala-portal
5
1
Fork 0
Code Issues 34 Pull requests 2 Projects 2 Releases 3 Packages 2 Activity Actions

Support for SOCKS proxy configuration on control planes #344

Merged
tobru merged 1 commit from socks-proxy-per-controlplane into main 2025-12-22 14:32:01 +00:00
Conversation 2 Commits 1 Files changed 3 +39
tobru commented 2025-12-22 14:26:15 +00:00
Owner
Copy link

Allow specifying a SOCKS proxy URL per control plane. Use case: Connect to a control plane via a user-space VPN like Netbird or Tailscale.

Allow specifying a SOCKS proxy URL per control plane. Use case: Connect to a control plane via a user-space VPN like Netbird or Tailscale.
support for SOCKS proxy configuration on control planes
All checks were successful
Tests / test (push) Successful in 30s
Details
0acc67c09d
tobru merged commit ecb7c9b0d8 into main 2025-12-22 14:32:01 +00:00
tobru deleted branch socks-proxy-per-controlplane 2025-12-22 14:32:02 +00:00
rixx commented 2026-01-19 14:27:10 +00:00
Member
Copy link

@tobru What does the typical SOCKS URL look like in practical use? Will it contain URL-based credentials or is it just a URL? Might be worth using a URLField for this, or at least an input validator. (This validator could also be reused in the SOCKS client class to make sure at instantiation that the URL is really valid.)

@tobru What does the typical SOCKS URL look like in practical use? Will it contain URL-based credentials or is it just a URL? Might be worth using a URLField for this, or at least an input validator. (This validator could also be reused in the SOCKS client class to make sure at instantiation that the URL is really valid.)
rixx commented 2026-01-19 14:32:02 +00:00
Member
Copy link

@tobru Also re servala/servala-portal@6fa4b09b6a – the models file is already fairly huge, and putting a HTTP client in there makes it even larger and is not great re: separation of concerns imo. The SOCKSRESTClientObject also does not call super().__init__(), and instead vendors most of it. Might be worth calling super() and then overriding pool_manager afterwards, cutting down on code duplication.

@tobru Also re https://servala.app.codey.ch/servala/servala-portal/commit/6fa4b09b6a4cdd4e7acb099f2b483b26030f98dc – the models file is already fairly huge, and putting a HTTP client in there makes it even larger and is not great re: separation of concerns imo. The `SOCKSRESTClientObject` also does not call `super().__init__()`, and instead vendors most of it. Might be worth calling `super()` and then overriding `pool_manager` afterwards, cutting down on code duplication.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
API

Relates to API

  
Billing

Billing and invoicing

  
UI/UX

User interface and user experience

  
dependencies

Dependencies Update

  
bug

Something is not working

  
change

Change an existing feature

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No labels
API
Billing
UI/UX
dependencies
bug
change
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
servala/servala-portal!344
No description provided.