servala/servala-portal
5
1
Fork 0
Code Issues 31 Pull requests 3 Projects 2 Releases 3 Packages 2 Activity Actions

Add display name field #331

Merged
tobru merged 18 commits from 290-display-name into main 2025-12-11 15:33:00 +00:00
Conversation 6 Commits 18 Files changed 24 +988 -225
rixx commented 2025-12-09 09:00:09 +00:00
Member
Copy link

ref #290

ref #290
rixx added 7 commits 2025-12-09 09:00:09 +00:00
Fix default form config
All checks were successful
Tests / test (push) Successful in 29s
Details
86feb0ae4f
rixx added 1 commit 2025-12-09 15:16:37 +00:00
Fix custom form config
All checks were successful
Tests / test (push) Successful in 29s
Details
ce92f6f29e
rixx added 1 commit 2025-12-09 15:17:09 +00:00
Fix FQDN generation
All checks were successful
Tests / test (push) Successful in 29s
Details
7a88b2b83a
requested review from tobru 2025-12-09 15:37:41 +00:00
tobru commented 2025-12-09 15:38:13 +00:00
Owner
Copy link

Editing a service fails with:

TypeError: VSHNForgejo() got unexpected keyword arguments: 'name'

Other than that, I think LGTM. Needs a bit more testing I guess, now that the dev cluster is there again...

Editing a service fails with: ``` TypeError: VSHNForgejo() got unexpected keyword arguments: 'name' ``` Other than that, I think LGTM. Needs a bit more testing I guess, now that the dev cluster is there again...
rixx force-pushed 290-display-name from 7a88b2b83a to 848e5162bc 2025-12-10 09:21:15 +00:00 Compare
rixx commented 2025-12-10 09:22:22 +00:00
Author
Member
Copy link

Fixed the broken update page. I think atm we do not immediately sync the display name annotation if it changes (sync would be part of the billing annotation sync, though). Should I add an annotation sync on display name change?

Fixed the broken update page. I think atm we do not immediately sync the display name annotation if it changes (sync would be part of the billing annotation sync, though). Should I add an annotation sync on display name change?
tobru commented 2025-12-10 10:17:03 +00:00
Owner
Copy link

Should I add an annotation sync on display name change?

Yes, I think that makes sense to have.

> Should I add an annotation sync on display name change? Yes, I think that makes sense to have.
rixx force-pushed 290-display-name from 848e5162bc to 392653aace 2025-12-10 12:01:52 +00:00 Compare
tobru commented 2025-12-11 10:39:51 +00:00
Owner
Copy link

In general, it works. Some things need refinement:

  • Generating the FQDN from the display name needs to make sure it's a valid FQDN, for example when entering a space, it would also add a space to the FQDN which is invalid. Let's sanitize it, for example a space might become a -. Maybe there is a generic "sanitization" approach?
  • Let's rename "Resource Name" into "Instance ID"

Other than that, I'd say LGTM

In general, it works. Some things need refinement: * Generating the FQDN from the display name needs to make sure it's a valid FQDN, for example when entering a space, it would also add a space to the FQDN which is invalid. Let's sanitize it, for example a space might become a `-`. Maybe there is a generic "sanitization" approach? * Let's rename "Resource Name" into "Instance ID" Other than that, I'd say LGTM
rixx added 2 commits 2025-12-11 12:14:25 +00:00
Rename Resource Name to Instance ID
All checks were successful
Tests / test (push) Successful in 35s
Details
f3986a875a
rixx commented 2025-12-11 12:15:52 +00:00
Author
Member
Copy link

FQDN is now getting basic sanitizing, and the field is called "Instance ID" in all places.

FQDN is now getting basic sanitizing, and the field is called "Instance ID" in all places.
tobru approved these changes 2025-12-11 15:32:31 +00:00
tobru added the
UI/UX
 label 2025-12-11 15:32:40 +00:00
tobru merged commit cee4b2a8bc into main 2025-12-11 15:33:00 +00:00
tobru deleted branch 290-display-name 2025-12-11 15:33:00 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
tobru
Labels
Clear labels   
API

Relates to API

  
Billing

Billing and invoicing

  
UI/UX

User interface and user experience

  
dependencies

Dependencies Update

  
bug

Something is not working

  
change

Change an existing feature

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No labels
API
Billing
UI/UX
dependencies
bug
change
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: servala/servala-portal#331
No description provided.
Delete branch "290-display-name"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?