Service Configuration Form Mandatory Field Handling #156
Labels
No labels
API
Billing
UI/UX
dependencies
bug
change
duplicate
enhancement
help wanted
invalid
question
wontfix
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: servala/servala-portal#156
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Stories
As a user, I want to have a meaningful service configuration form in regards to mandatory fields.
Implementation Notes
spec.parameters.service.fqdnorspec.parameters.service.collabora.*.I fixed the mandatory field detection in the PR.
However, I have concerns regarding the grouping of all mandatory fields in the main section: This would remove fields from their context, making the form harder to parse, I think. In the Nextcloud case, for example, both of the Collabora fields are required – but if there was a third Collabora setting that was optional, it would now be placed away from the other two (required) fields.
Alternative options could be to jump to required fields that are still missing when users attempt to submit the form, and/or to add a star to tabs containing mandatory fields. We could also consider moving away from the tab concept and instead use accordions (details/summary elements) and auto-expand all that contain manadatory fields (which would allow browsers to auto-scroll to missing fields).
Lmk what you think – happy to implement what you think is best, just wanted to raise the concerns I saw when starting to implement the separated mandatory fields.
Thanks for the input. I propose we go with a star in the tab where there are mandatory fields and make the mandatory fields visually stand out a bit more than just a star which might be easily overlooked.
Red stars in tab names + more prominent styling for mandatory fields in CRD forms is now in #175.