Service pages improvements

rixx commented

2025-07-11 11:22:43 +00:00

Member

Fix service tile height
Add "Learn more" link display
Show all external links on service detail page
~~Show "Learn more" link on offering detail page~~
Show service external links on offering detail page
Show service offering description text

#132 - [x] Fix service tile height - [x] Add "Learn more" link display - [x] Show all external links on service detail page - [ ] ~~Show "Learn more" link on offering detail page~~ - [x] Show service external links on offering detail page - [x] Show service offering description text

rixx force-pushed 132-frontend-improvements from 3c365c0824 to e24e368654

2025-07-11 11:23:09 +00:00

Compare

rixx force-pushed 132-frontend-improvements from e24e368654 to 5b876de18a

2025-08-01 11:11:39 +00:00

Compare

rixx commented

2025-08-01 11:23:49 +00:00

Author

Member

I'm not entirely clear on the "Learn more" link per service offering – everything else should be resolved, though configuring the links requires entering JSON (documented structure) manually.

rixx changed title from ~~WIP: Service pages improvements~~ to Service pages improvements

2025-08-01 11:23:55 +00:00

tobru commented

2025-08-18 12:21:54 +00:00

Owner

Added the following JSON to a service:

{"url": "https://www.servala.com/", "title": "link 1", "featured": false}

This ended in:

AttributeError at /org/my-acme-7/services/

'str' object has no attribute 'get'

Error during template rendering

In template /home/tobru/src/servala/portal/src/servala/frontend/templates/frontend/organizations/services.html, error at line 40

The space between the cards in the service listing and the footer appears to be too narrow compared to other pages.

Regarding the "Learn more" link: Maybe it's enough with the external links. I'll check it when the above issue is fixed.

Added the following JSON to a service: ``` {"url": "https://www.servala.com/", "title": "link 1", "featured": false} ``` This ended in: ``` AttributeError at /org/my-acme-7/services/ 'str' object has no attribute 'get' Error during template rendering In template /home/tobru/src/servala/portal/src/servala/frontend/templates/frontend/organizations/services.html, error at line 40 ``` The space between the cards in the service listing and the footer appears to be too narrow compared to other pages. Regarding the "Learn more" link: Maybe it's enough with the external links. I'll check it when the above issue is fixed.

tobru commented

2025-08-19 05:57:40 +00:00

Owner

Forget about the error message! I was stupid enough to forget that this should be a JSON array. With that, it works:

[{"url": "https://www.servala.com/", "title": "link 1", "featured": true}]

Besides the spacing issue, I think this PR is done. There's no need for a separate "Learn more" link.

Forget about the error message! I was stupid enough to forget that this should be a JSON array. With that, it works: ``` [{"url": "https://www.servala.com/", "title": "link 1", "featured": true}] ``` Besides the spacing issue, I think this PR is done. There's no need for a separate "Learn more" link.

tobru commented

2025-08-19 06:00:27 +00:00

Owner

Maybe something like https://github.com/bhch/django-jsonform could help to work with JSONFields?