From 493f68eedf82eaab03f57d1cd9808f3d6ddcbda1 Mon Sep 17 00:00:00 2001 From: Tobias Kunze Date: Thu, 26 Jun 2025 17:21:18 +0200 Subject: [PATCH 1/2] Make loop more efficient --- src/servala/core/crd.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/servala/core/crd.py b/src/servala/core/crd.py index 6e17949..f4d9661 100644 --- a/src/servala/core/crd.py +++ b/src/servala/core/crd.py @@ -233,7 +233,7 @@ class CrdModelFormMixin: # General fieldset for non-spec fields general_fields = [ field_name - for field_name, field in self.fields.items() + for field_name in self.fields.keys() if not field_name.startswith("spec.") ] if general_fields: From dabf758ced451cb99b69084dbb93d3b05f7af7f9 Mon Sep 17 00:00:00 2001 From: Tobias Kunze Date: Thu, 26 Jun 2025 17:21:24 +0200 Subject: [PATCH 2/2] Fix bug exclusive to second-level config fields --- src/servala/core/crd.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/servala/core/crd.py b/src/servala/core/crd.py index f4d9661..3a27c0b 100644 --- a/src/servala/core/crd.py +++ b/src/servala/core/crd.py @@ -268,7 +268,7 @@ class CrdModelFormMixin: if not top_level_fieldsets.get(fieldset_key): top_level_fieldsets[fieldset_key] = { "fields": [], - "fieldsets": [], + "fieldsets": {}, "title": f"{deslugify(parts[2])}", } top_level_fieldsets[fieldset_key]["fields"].append(field_name)