From cd886df05b7e3959cdcca7a0fa00f9d6837f887a Mon Sep 17 00:00:00 2001
From: Tobias Kunze <r@rixx.de>
Date: Wed, 15 Oct 2025 14:34:38 +0200
Subject: [PATCH] Add ServiceDefinition.advanced_fields

ref #204
---
 src/servala/core/admin.py                     | 27 +++++++++++++++++++
 .../0014_servicedefinition_advanced_fields.py | 27 +++++++++++++++++++
 src/servala/core/models/service.py            | 15 ++++++++++-
 3 files changed, 68 insertions(+), 1 deletion(-)
 create mode 100644 src/servala/core/migrations/0014_servicedefinition_advanced_fields.py

diff --git a/src/servala/core/admin.py b/src/servala/core/admin.py
index efe935c..1aec22a 100644
--- a/src/servala/core/admin.py
+++ b/src/servala/core/admin.py
@@ -318,8 +318,35 @@ class ServiceDefinitionAdmin(admin.ModelAdmin):
                 "description": _("API definition for the Kubernetes Custom Resource"),
             },
         ),
+        (
+            _("Form Configuration"),
+            {
+                "fields": ("advanced_fields",),
+                "description": _(
+                    "Configure which fields should be hidden behind an 'Advanced' toggle in the form"
+                ),
+            },
+        ),
     )
 
+    def get_form(self, request, obj=None, **kwargs):
+        form = super().get_form(request, obj, **kwargs)
+        # JSON schema for advanced_fields field
+        advanced_fields_schema = {
+            "type": "array",
+            "title": "Advanced Fields",
+            "items": {
+                "type": "string",
+                "title": "Field Name",
+                "description": "Field name in dot notation (e.g., spec.parameters.monitoring.enabled)",
+            },
+        }
+        if "advanced_fields" in form.base_fields:
+            form.base_fields["advanced_fields"].widget = JSONFormWidget(
+                schema=advanced_fields_schema
+            )
+        return form
+
     def get_exclude(self, request, obj=None):
         # Exclude the original api_definition field as we're using our custom fields
         return ["api_definition"]
diff --git a/src/servala/core/migrations/0014_servicedefinition_advanced_fields.py b/src/servala/core/migrations/0014_servicedefinition_advanced_fields.py
new file mode 100644
index 0000000..20632b9
--- /dev/null
+++ b/src/servala/core/migrations/0014_servicedefinition_advanced_fields.py
@@ -0,0 +1,27 @@
+# Generated by Django 5.2.7 on 2025-10-17 03:23
+
+from django.db import migrations, models
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ("core", "0013_controlplane_wildcard_dns"),
+    ]
+
+    operations = [
+        migrations.AddField(
+            model_name="servicedefinition",
+            name="advanced_fields",
+            field=models.JSONField(
+                blank=True,
+                default=list,
+                help_text=(
+                    "Array of field names that should be hidden behind an 'Advanced' toggle. "
+                    "Use dot notation (e.g., ['spec.parameters.monitoring.enabled', 'spec.parameters.backup.schedule'])"
+                ),
+                null=True,
+                verbose_name="Advanced fields",
+            ),
+        ),
+    ]
diff --git a/src/servala/core/models/service.py b/src/servala/core/models/service.py
index f67f454..42fc500 100644
--- a/src/servala/core/models/service.py
+++ b/src/servala/core/models/service.py
@@ -359,6 +359,16 @@ class ServiceDefinition(ServalaModelMixin, models.Model):
         null=True,
         blank=True,
     )
+    advanced_fields = models.JSONField(
+        verbose_name=_("Advanced fields"),
+        help_text=_(
+            "Array of field names that should be hidden behind an 'Advanced' toggle. "
+            "Use dot notation (e.g., ['spec.parameters.monitoring.enabled', 'spec.parameters.backup.schedule'])"
+        ),
+        null=True,
+        blank=True,
+        default=list,
+    )
     service = models.ForeignKey(
         to="Service",
         on_delete=models.CASCADE,
@@ -499,7 +509,10 @@ class ControlPlaneCRD(ServalaModelMixin, models.Model):
 
         if not self.django_model:
             return
-        return generate_model_form_class(self.django_model)
+        advanced_fields = self.service_definition.advanced_fields or []
+        return generate_model_form_class(
+            self.django_model, advanced_fields=advanced_fields
+        )
 
 
 class ServiceOffering(ServalaModelMixin, models.Model):